Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misc assertion errors #1085

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Fix misc assertion errors #1085

merged 2 commits into from
Sep 9, 2024

Conversation

Shangyint
Copy link
Collaborator

No description provided.

@arnavsinghvi11
Copy link
Collaborator

Thanks @Shangyint ! will this change break any existing caches with the assertions notebooks in the examples folder?

@Shangyint
Copy link
Collaborator Author

Shangyint commented May 31, 2024 via email

@arnavsinghvi11
Copy link
Collaborator

I see yes we can do that or we can remove the cache for now to avoid blocking modifications to assertions behavior since besides the intro notebook, the rest of the example notebooks are not fully cached yet

@Shangyint
Copy link
Collaborator Author

I see yes we can do that or we can remove the cache for now to avoid blocking modifications to assertions behavior since besides the intro notebook, the rest of the example notebooks are not fully cached yet

Agreed! Later would be good to develop a standardized way to stage all caches and automatically update them based on need.

@okhat okhat merged commit 2d1b881 into main Sep 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants